IDBCursorWithValue->IDBCursor #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the draft spec (as opposed to the Recommendation), only `openKeyCursor` could create a cursor which implements `IDBCursorWithValue`. Otherwise, it should be `IDBCursor`.
brettz9
added a commit
to brettz9/IndexedDBShim
that referenced
this pull request
Jun 15, 2016
brettz9
added a commit
to brettz9/IndexedDBShim
that referenced
this pull request
Jun 16, 2016
…g fix: Fix test to reflect latest draft spec; see brettz9/web-platform-tests#1 ; Testing fix: Change example to expect `ConstraintError` (since object store already existing per test)--though perhaps should ensure it is not yet existing; Test scaffolding fix: Fix args to initionalSituation(); Test scaffolding fix: Fix test ok condition, typo; Adapt changes from wibimaster:Fix_Object_Type to allow object type encoding/decoding; Test scaffolding fix: assertions; Fix: Allow `__versionTransaction` not to exist (if user calling it wrong) and test it so it will return an `InvalidStateError`; Fix: Allow empty string keyPath for index to return value as is (for handling non-object values as keys); Fix: Ensure "prev" cursor will iterate in descending order on primary key (sort by keyPath-indicated value then primary key); Fix: Ensure the error thrown for a count <=0 to `advance()` is a genuine `TypeError` - Fix: Ensure other bad counts passed to `advance()` (non-numbers or non-finite numbers); Fix: throw `TypeError` as per W3C tests (even though the spec is silent on bad counts except for count=0); Fix: Add transaction to `IDBCursor` request; Fix: Ensure will throw when "got value flag" is unset during call to `continue` or `advance`; Fix: For `advance`/`continue`, throw if the cursor source or effective object store has been deleted; Fix: Replace `instanceof` checks with `Array.isArray()` for arrays and with duck-typing otherwise (for reliability with cross-window/module data); Refactoring: Where safe, switch from typeof ... === 'undefined' to check against undefined (safe for strict mode implicit in modules); (Testing: W3C IDBCursor.advance.js tests now all passing); -Refactoring: Use spread operator in place of `arguments` where named args not needed (also may be more future-proof); Refactoring: minor, including ES6;
brettz9
added a commit
to brettz9/IndexedDBShim
that referenced
this pull request
Jun 16, 2016
-Fix: Adapt changes from wibimaster:Fix_Object_Type to allow object type encoding/decoding; -Fix: Allow `__versionTransaction` not to exist (if user calling it wrong) and test it so it will return an `InvalidStateError`; -Fix: Allow empty string keyPath for index to return value as is (for handling non-object values as keys); -Fix: Ensure "prev" cursor will iterate in descending order on primary key (sort by keyPath-indicated value then primary key); -Fix: Ensure the error thrown for a count <=0 to `advance()` is a genuine `TypeError` -Fix: Ensure other bad counts passed to `advance()` (non-numbers or non-finite numbers); -Fix: throw `TypeError` as per W3C tests (even though the spec is silent on bad counts except for count=0); -Fix: Add transaction to `IDBCursor` request; -Fix: Ensure will throw when "got value flag" is unset during call to `continue` or `advance`; -Fix: For `advance`/`continue`, throw if the cursor source or effective object store has been deleted; -Fix: Replace `instanceof` checks with `Array.isArray()` for arrays and with duck-typing otherwise (for reliability with cross-window/module data); -Testing fix: Fix test to reflect latest draft spec -- see brettz9/web-platform-tests#1 ; -Testing fix: Change example to expect `ConstraintError` (since object store already existing per test)--though perhaps should ensure it is not yet existing; -Test scaffolding fix: Fix args to initionalSituation(); -Test scaffolding fix: Fix test ok condition, typo; -Test scaffolding fix: assertions; (Testing: W3C IDBCursor.advance.js tests now all passing); -Refactoring: Where safe, switch from typeof ... === 'undefined' to check against undefined (safe for strict mode implicit in modules); -Refactoring: Use spread operator in place of `arguments` where named args not needed (also may be more future-proof); -Refactoring: minor, including ES6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the draft spec (as opposed to the Recommendation), only
openKeyCursorcould create a cursor which implementsIDBCursorWithValue. Otherwise, it should beIDBCursor.