-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(condition): Add Number Greater Than Inspector (#183)
* feat(condition): Add Number Greater Than Inspector * refactor: Vars, Tests * build(config): Add Number Greater Than Inspector * fix: Add to Factory * refactor: Add nolint for gocyclo
- Loading branch information
Showing
6 changed files
with
242 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
package condition | ||
|
||
import ( | ||
"context" | ||
"encoding/json" | ||
"strconv" | ||
|
||
"github.com/brexhq/substation/config" | ||
"github.com/brexhq/substation/message" | ||
) | ||
|
||
func newNumberGreaterThan(_ context.Context, cfg config.Config) (*numberGreaterThan, error) { | ||
conf := numberConfig{} | ||
if err := conf.Decode(cfg.Settings); err != nil { | ||
return nil, err | ||
} | ||
|
||
insp := numberGreaterThan{ | ||
conf: conf, | ||
} | ||
|
||
return &insp, nil | ||
} | ||
|
||
type numberGreaterThan struct { | ||
conf numberConfig | ||
} | ||
|
||
func (insp *numberGreaterThan) Inspect(ctx context.Context, msg *message.Message) (output bool, err error) { | ||
if msg.IsControl() { | ||
return false, nil | ||
} | ||
|
||
if insp.conf.Object.SourceKey == "" { | ||
f, err := strconv.ParseFloat(string(msg.Data()), 64) | ||
if err != nil { | ||
return false, err | ||
} | ||
|
||
return insp.match(f), nil | ||
} | ||
|
||
v := msg.GetValue(insp.conf.Object.SourceKey) | ||
return insp.match(v.Float()), nil | ||
} | ||
|
||
func (c *numberGreaterThan) match(f float64) bool { | ||
return f > c.conf.Value | ||
} | ||
|
||
func (c *numberGreaterThan) String() string { | ||
b, _ := json.Marshal(c.conf) | ||
return string(b) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,158 @@ | ||
package condition | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
"github.com/brexhq/substation/config" | ||
"github.com/brexhq/substation/message" | ||
) | ||
|
||
var _ inspector = &numberGreaterThan{} | ||
|
||
var numberGreaterThanTests = []struct { | ||
name string | ||
cfg config.Config | ||
test []byte | ||
expected bool | ||
}{ | ||
// Integers | ||
{ | ||
"pass", | ||
config.Config{ | ||
Settings: map[string]interface{}{ | ||
"object": map[string]interface{}{ | ||
"source_key": "foo", | ||
}, | ||
"value": 1, | ||
}, | ||
}, | ||
[]byte(`{"foo":10}`), | ||
true, | ||
}, | ||
{ | ||
"pass", | ||
config.Config{ | ||
Settings: map[string]interface{}{ | ||
"value": 1, | ||
}, | ||
}, | ||
[]byte(`10`), | ||
true, | ||
}, | ||
{ | ||
"fail", | ||
config.Config{ | ||
Settings: map[string]interface{}{ | ||
"object": map[string]interface{}{ | ||
"source_key": "foo", | ||
}, | ||
"value": 10, | ||
}, | ||
}, | ||
[]byte(`{"foo":1}`), | ||
false, | ||
}, | ||
{ | ||
"fail", | ||
config.Config{ | ||
Settings: map[string]interface{}{ | ||
"value": 10, | ||
}, | ||
}, | ||
[]byte(`1`), | ||
false, | ||
}, | ||
// Floats | ||
{ | ||
"pass", | ||
config.Config{ | ||
Settings: map[string]interface{}{ | ||
"value": 1, | ||
}, | ||
}, | ||
[]byte(`1.5`), | ||
true, | ||
}, | ||
{ | ||
"pass", | ||
config.Config{ | ||
Settings: map[string]interface{}{ | ||
"value": 1.1, | ||
}, | ||
}, | ||
[]byte(`1.5`), | ||
true, | ||
}, | ||
{ | ||
"fail", | ||
config.Config{ | ||
Settings: map[string]interface{}{ | ||
"object": map[string]interface{}{ | ||
"source_key": "foo", | ||
}, | ||
"value": 1.5, | ||
}, | ||
}, | ||
[]byte(`{"foo":1.1}`), | ||
false, | ||
}, | ||
{ | ||
"fail", | ||
config.Config{ | ||
Settings: map[string]interface{}{ | ||
"value": 1.5, | ||
}, | ||
}, | ||
[]byte(`1`), | ||
false, | ||
}, | ||
} | ||
|
||
func TestNumberGreaterThan(t *testing.T) { | ||
ctx := context.TODO() | ||
|
||
for _, test := range numberGreaterThanTests { | ||
t.Run(test.name, func(t *testing.T) { | ||
message := message.New().SetData(test.test) | ||
insp, err := newNumberGreaterThan(ctx, test.cfg) | ||
if err != nil { | ||
t.Fatal(err) | ||
} | ||
|
||
check, err := insp.Inspect(ctx, message) | ||
if err != nil { | ||
t.Error(err) | ||
} | ||
|
||
if test.expected != check { | ||
t.Errorf("expected %v, got %v", test.expected, check) | ||
t.Errorf("settings: %+v", test.cfg) | ||
t.Errorf("test: %+v", string(test.test)) | ||
} | ||
}) | ||
} | ||
} | ||
|
||
func benchmarkNumberGreaterThan(b *testing.B, insp *numberGreaterThan, message *message.Message) { | ||
ctx := context.TODO() | ||
for i := 0; i < b.N; i++ { | ||
_, _ = insp.Inspect(ctx, message) | ||
} | ||
} | ||
|
||
func BenchmarkNumberGreaterThan(b *testing.B) { | ||
for _, test := range numberGreaterThanTests { | ||
insp, err := newNumberGreaterThan(context.TODO(), test.cfg) | ||
if err != nil { | ||
b.Fatal(err) | ||
} | ||
|
||
b.Run(test.name, | ||
func(b *testing.B) { | ||
message := message.New().SetData(test.test) | ||
benchmarkNumberGreaterThan(b, insp, message) | ||
}, | ||
) | ||
} | ||
} |