Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(terraform): Remove Lifecycle Locals in KDS Module #149

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented Mar 20, 2024

Description

  • Removes the lifecycle locals in the Terraform Kinesis Data Stream module

Motivation and Context

Terraform won't accept variables in lifecycle.ignore_changes and returns the error A static list expression is required.. This has been widely discussed in several issues on the Terraform project, with a particularly long and unresolved discussion here.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review March 20, 2024 23:47
@jshlbrd jshlbrd requested a review from a team as a code owner March 20, 2024 23:47
@jshlbrd jshlbrd merged commit 5ca6807 into main Mar 21, 2024
4 checks passed
@jshlbrd jshlbrd deleted the jshlbrd/build/tf-cw-locals branch March 21, 2024 14:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants