Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(config): add ID to conditional pattern #207

Merged
merged 1 commit into from
Jul 18, 2024
Merged

build(config): add ID to conditional pattern #207

merged 1 commit into from
Jul 18, 2024

Conversation

shellcromancer
Copy link
Contributor

Description

Adds the configuration ID in the Substation conditional pattern to locate troublesome configurations from logs.

Motivation and Context

This was missed during the feature work in #181. Brings feature parity when debugging configurations.

How Has This Been Tested?

Outputted config.json files now have an ID field.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@shellcromancer shellcromancer requested a review from a team as a code owner July 18, 2024 20:50
@shellcromancer shellcromancer changed the title fix(build/config): add ID to conditional pattern build(config): add ID to conditional pattern Jul 18, 2024
@shellcromancer shellcromancer merged commit 227a5d9 into main Jul 18, 2024
6 checks passed
@shellcromancer shellcromancer deleted the 07-18-fix_build_config_add_id_to_conditional_pattern branch July 18, 2024 21:05
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshlbrd jshlbrd jshlbrd approved these changes

Assignees

@jshlbrd jshlbrd

@Mallika05 Mallika05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shellcromancer @jshlbrd @Mallika05