Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transform): Add SkipMissingValues Flag to Test Transform #273

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jshlbrd
Copy link
Collaborator

@jshlbrd jshlbrd commented Nov 7, 2024

Description

  • Fixes an issue with test messages due to a missing flag

Motivation and Context

In v2.3.0 the Message package was refactored to use Flags for controlling transform behavior that was previously not configurable, but adding flags to the creation of test messages was missed. This doesn't impact production deployments, so it's not a breaking fix.

How Has This Been Tested?

Any config unit tests that fail in v2.3.0 due to missing values should now pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd changed the title fix(transform): Add SkipMissingValues Flag fix(transform): Add SkipMissingValues Flag to Test Transform Nov 7, 2024
@jshlbrd jshlbrd marked this pull request as ready for review November 7, 2024 18:21
@jshlbrd jshlbrd requested a review from a team as a code owner November 7, 2024 18:21
@jshlbrd jshlbrd merged commit 21ff1db into main Nov 7, 2024
8 checks passed
@jshlbrd jshlbrd deleted the fix/test-message-flag branch November 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants