Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update v2 migration guide #276

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

shellcromancer
Copy link
Contributor

Description

This fixes examples in the v2 migration guide for sub.cnd.meta.* conditions that replace for_each conditions by removing the array parameter. Users following this guide would get Jsonnet that failed to build.

Motivation and Context

Discovered this while migrating an old configuration and following the guide resulted in a broken config.

How Has This Been Tested?

Verified that the Jsonnet could be built and passed with substation vet

Types of changes

  • Bug fix (non-breaking change which fixes an issue) * of documentation*
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Fix sub.cnd.meta.* examples that replace for_each conditions.
@shellcromancer shellcromancer requested a review from a team as a code owner November 14, 2024 20:45
@shellcromancer shellcromancer merged commit 0b5934b into main Nov 14, 2024
7 checks passed
@shellcromancer shellcromancer deleted the dstinson-diess/fix/v2-guide-for-each-cnd branch November 14, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants