-
Notifications
You must be signed in to change notification settings - Fork 44
Support node v4.0 #27
Comments
I'm having a problem debugging why node-libpq fails to build on node v4.0.0 When I run
I don't really have time to debug this right now - do you have any ideas? |
The build error here has a bit more info: https://travis-ci.org/sequelize/sequelize/jobs/79843094 |
I figured out the issue! 💃 Apparently there's some stuff still fubar with npm, nan, and node-gyp in the most recent version of npm: nodejs/node-gyp#711 npm@2.14.4 fixes the issue. It's still pre-release so you can either add a .travis.yml step to manually install it:
or we can wait until its released not as a pre-release flag. Then this should compile normally. I verified it works locally with |
Thanks for looking into it @brianc. I think we'll start out with using a pre-release. |
Any status on Node 4.X support? We are using pg-native & sequelize, and would like to update our project to node 4 asap. Thanks |
@brianc on my machine
|
@mickhansen pg-native & libpq are both buliding fine for me on node v4.0.0 now. Are they working for you?
|
iojs-3.3.1 has build error https://s3.amazonaws.com/archive.travis-ci.org/jobs/82477303/log.txt make: Entering directory `/home/travis/build/minicloud/minicloud/node_modules/pg-native/node_modules/libpq/build' |
I can build pg-native & libpq in my local machine (OSX 10.11 & node 4.1.2), but I get the following error in Travis CI:
|
I had same exact issue like @pensierinmusica described, with Atlassian Bamboo server running on ubuntu:
|
Does this part of the error message help at all? I'm not totally familiar with your system, but you'll likely need to install the postgresql dev headers:
|
@brianc you were right,
|
👍 glad you got it sorted out! On Tue, Oct 27, 2015 at 11:31 AM, Milos Solujic notifications@github.com
|
This still fails on npm 2.14.7. Any idea? |
@mghaderyan-nisum-com Can you show error message? because all looks fine: $ nvm use 4.2.2
Now using node v4.2.2 (npm v2.14.7)
$ npm -v
2.14.7
$ npm install pg-native
/
> libpq@1.8.0 install /home/kirill/tmp/node_modules/pg-native/node_modules/libpq
> node-gyp rebuild
make: Entering directory '/home/kirill/tmp/node_modules/pg-native/node_modules/libpq/build'
CXX(target) Release/obj.target/addon/src/connection.o
CXX(target) Release/obj.target/addon/src/connect-async-worker.o
CXX(target) Release/obj.target/addon/src/addon.o
SOLINK_MODULE(target) Release/obj.target/addon.node
COPY Release/addon.node
make: Leaving directory '/home/kirill/tmp/node_modules/pg-native/node_modules/libpq/build'
pg-native@1.9.0 node_modules/pg-native
├── pg-types@1.6.0
├── readable-stream@1.0.31 (isarray@0.0.1, string_decoder@0.10.31, inherits@2.0.1, core-util-is@1.0.2)
└── libpq@1.8.0 (bindings@1.2.1, nan@2.1.0) |
Sorry my mistake. I think I do not have pg_config on CI server. I was trying to run my migration scripts using db-migrate that depends on this library.
|
As I understand CI service is Travis? Can you show .travis.yml? Or you can see my working travis config for project that use pg-native. |
Thanks. the following is my travis.yml:
|
yeah you need to add that C++ mumbo jumbo to your travis config. Thanks for On Mon, Nov 23, 2015 at 11:59 AM, Meysam Ghaderyan <notifications@github.com
|
This is the stuff you'll need in yer travis config: https://github.com/chromaway/chromanode/blob/86691ed5c28a50c19a79185f8ab465714a540e31/.travis.yml#L6 |
Thanks a lot for your help Brian. |
I'm sure you're aware of it, so just opening this issue as a tracker.
Sequelize depends on this library so looking forward to being able to run our test suite for 4.0 aswell :)
The text was updated successfully, but these errors were encountered: