Add test for pool.end method

brianc · Jun 12, 2024 · 009acb9 · 009acb9
1 parent 33e0f16
commit 009acb9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js
@@ -167,10 +167,10 @@ class Pool extends EventEmitter {
     client.end(() => {
       this.emit('remove', client)
 
-      if (typeof callback === "function") {
+      if (typeof callback === 'function') {
         callback()
       }
-    }) 
+    })
   }
 
   connect(cb) {
@@ -348,7 +348,7 @@ class Pool extends EventEmitter {
         this.log('remove expended client')
       }
 
-      return  this._remove(client, this._pulseQueue.bind(this))
+      return this._remove(client, this._pulseQueue.bind(this))
     }
 
     const isExpired = this._expired.has(client)

diff --git a/packages/pg-pool/test/ending.js b/packages/pg-pool/test/ending.js
@@ -37,4 +37,14 @@ describe('pool ending', () => {
       expect(res.rows[0].name).to.equal('brianc')
     })
   )
+
+  it('pool.end() - finish pending queries', async () => {
+    const pool = new Pool({ max: 20 })
+    let completed = 0
+    for (let x = 1; x <= 20; x++) {
+      pool.query('SELECT $1::text as name', ['brianc']).then(() => completed++)
+    }
+    await pool.end()
+    expect(completed).to.equal(20)
+  })
 })