chore (ci): add node v20 to build matrix (#3148)

* chore (ci): add node v20 to build matrix * skip pg-native tests on node 20 --------- Co-authored-by: alxndrsn <alxndrsn>
brianc · Mar 15, 2024 · a717c00 · a717c00
1 parent aedae81
commit a717c00
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -42,6 +42,7 @@ jobs:
           - '14'
           - '16'
           - '18'
+          - '20'
         os:
           - ubuntu-latest
     name: Node.js ${{ matrix.node }} (${{ matrix.os }})
@@ -54,6 +55,7 @@ jobs:
         PGTESTNOSSL: 'true'
         SCRAM_TEST_PGUSER: scram_test
         SCRAM_TEST_PGPASSWORD: test4scram
+        TEST_SKIP_NATIVE: ${{ matrix.node == 20 }}
     steps:
       - name: Show OS
         run: |

diff --git a/packages/pg/Makefile b/packages/pg/Makefile
@@ -39,10 +39,14 @@ test-missing-native:
 
 test-native: test-connection
 	@echo "***Testing native bindings***"
+ifeq ($(TEST_SKIP_NATIVE), true)
+	@echo "***Skipping tests***"
+else
 	@npm i --no-save pg-native
 	@find test/native -name "*-tests.js" | $(node-command)
 	@find test/integration -name "*-tests.js" | $(node-command) native
 	@npm uninstall pg-native
+endif
 
 test-integration: test-connection
 	@echo "***Testing Pure Javascript***"