Remove confusing conditions #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charmander think you could rebase your branch with master so we pick up the fixes you did for travis? After that I'll happily merge, or you can if you want to be a contributor! |
Every path with `!this.values` results in `false` regardless of `this.binary`.
charmander
force-pushed
the
remove-confusing-conditions
branch
from
3ffb369
to
5369823
Compare
|
@brianc Done! |
|
Boom! Nice! |
|
Made you contributor! Feel free to merge whatever you think is best! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of these is unreachable, and the other suggests that there’s special behaviour where there isn’t.