Fix JSON-escaped characters in string array #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s not JSON.
|
@charmander - you're amazing. Would you like collaborator access to the repo so in any case where I'm out I don't end up blocking you? I'd love to have more co-maintainers helping out! |
|
Since CI is borked (you fixed it!! but on another PR) I'll run the tests locally & if they pass I'll get this one merged in. |
|
Works! Merged! Thank you! ❤️ |
|
@brianc Sure, thanks! And thank you for going through all this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved fix for #1147 over #1148.