chore: automatically replace var with let or const #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideViolante
commented
Oct 31, 2024
|
|
||
| var emptyRowFieldBuf = buffers.dataRow([]) | ||
| emptyRowFieldBuf = buffers.dataRow([]) |
There was a problem hiding this comment.
The only manual change was here due to: cannot redeclare variable. Same at line 52.
I think the line 42 and 46 can be safely removed because they are declared twice but only the 2nd var is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I didn't fix any code manually, just ran eslint.