Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-105048 Grab the pluginId #81981

Closed
wants to merge 6 commits into from
Closed

LPS-105048 Grab the pluginId #81981

wants to merge 6 commits into from

Conversation

victorg1991
Copy link

@victorg1991 victorg1991 mentioned this pull request Dec 13, 2019
Closed
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 18 seconds 177 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 80bda01119b09b2b5e100d6f9f36d97af06aac8f

Sender Branch:

Branch Name: pr-127
Branch GIT ID: 0a2960ec5a2014692afdb68323f8afa492d17867

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 8 out of 8 jobs passed

❌ ci:test:relevant - 24 out of 26 jobs passed in 1 hour 20 minutes 28 seconds 883 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 80bda01119b09b2b5e100d6f9f36d97af06aac8f

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6c0b5322d1e18eac4342d74f6522c7b7a9bbd7ed

ci:test:stable - 8 out of 8 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 24 out of 26 jobs PASSED
24 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 4e790a0:

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 5fce65e...8ec3275

@brianchandotcom
Copy link
Owner

@victorg1991 should this be sorted

import {
	EDIT_SEGMENTS_EXPERIENCE,
	CREATE_SEGMENTS_EXPERIENCE,
	SELECT_SEGMENTS_EXPERIENCE,
	DELETE_SEGMENTS_EXPERIENCE
}

@wincent fyi in modules/apps/layout/layout-content-page-editor-web/src/main/resources/META-INF/resources/page_editor/plugins/experience/index.js

@wincent wincent mentioned this pull request Dec 16, 2019
Closed
@wincent
Copy link

wincent commented Dec 16, 2019

@brianchandotcom: we currently sort import statements (relative to each other) and destructing bindings within objects, but we don't sort destructing bindings inside import statements, like the case you've highlighted here: I created liferay/eslint-config-liferay#124 to track enforcement of that.

@victorg1991 victorg1991 deleted the pr-127 branch January 17, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorg1991 @liferay-continuous-integration @brianchandotcom @wincent