Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4 Only] LPS-124354 Apply activity section on edit and view entry pages #97002

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-workflow#178 (Took 1 ci:forward attempt in 2 hours 4 minutes)

@rafaprax
@liferay-workflow

Original pull request comment:
Story https://issues.liferay.com/browse/LPS-121226

/cc @gabrielpramos @albinojunior @naraandrade

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 2 hours 1 minute

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 012adf4b2836179a5478bf04b5337955917fccb8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0ff04d9f73a4643abdd2b335581feef26b985b8a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 012adf4b2836179a5478bf04b5337955917fccb8

Sender Branch:

Branch Name: LPS-124354
Branch GIT ID: 3ea4338b080887a8e9854abe0776a479ce4dff65

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: ebf2c4f...24aee0f

@brianchandotcom
Copy link
Owner

@albinojunior is this in some kind of order?

import WorkflowInfoBar from '../../components/workflow-info-bar/WorkflowInfoBar.es';
import useDataLayouts from '../../hooks/useDataLayouts.es';
import ReassignEntryModal from './ReassignEntryModal.es';
import ActivitySection from './activity/ActivitySection.es';

Just seems weird.. they're not sorted nor do they have line breaks to show that order matters.

@albinojunior
Copy link

albinojunior commented Dec 17, 2020

This is automatic sorted by the eslint(@liferay/liferay/sort-imports) pattern.

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-124354-pr-178-sender-rafaprax-ts-1608136716921 branch December 24, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants