sum: more readable algorithms #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Sep 11, 2023
mknos
commented
- Declare one buffer size constant used by all algorithms
- Standard sum command has no -h option for help; treating it as an unknown option still prints usage string
- In sum2() remove unused variable $i
- In sum1() and crc32() replace ord+substr pattern with unpacking $buf before loop
- My test file produces same sum for -o {0,1,2} as previous version
* Declare one buffer size constant used by all algorithms
* Standard sum command has no -h option for help; treating it as an unknown option still prints usage string
* In sum2() remove unused variable $i
* In sum1() and crc32() replace ord+substr pattern with unpacking $buf before loop
* My test file produces same sum for -o {0,1,2} as previous version
briandfoy
reviewed
Sep 11, 2023
| [ I<filename ...> ] | ||
|
|
||
| =head1 DESCRIPTION | ||
|
|
||
| sum outputs three space seperated values: file CRC, file size, and | ||
| sum outputs three space separated values: file CRC, file size, and |
There was a problem hiding this comment.
This must be the most common typo. You've fixed this in more than a couple programs I think.
briandfoy
approved these changes
Sep 11, 2023
briandfoy
added
Type: enhancement
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.