Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

od: strange output for -b option #391

Merged
merged 1 commit into from
Dec 28, 2023
Merged

od: strange output for -b option #391

merged 1 commit into from
Dec 28, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 27, 2023

  • Output for -b flag is handled in octal1()
  • When debugging I observed $len == 1, but arr list contains 16 elements
  • $pffmt needs to repeat for each element of arr list
  • Repeating $pffmt was was handled correctly in other formatting functions, e.g. decimal(), so follow this
%perl od -b od | tail -n5
00013600 162 
00013620 157 
00013640 162 
00013660 145 
00013670

@mknos
od: strange output for -b option
3f2fa67 
* Output for -b flag is handled in octal1()
* When debugging I observed $len == 1, but arr list contains 16 elements
* $pffmt needs to repeat for each element of arr list
* Repeating $pffmt was was handled correctly in other formatting functions, e.g. decimal(), so follow this

%perl od -b od | tail -n5
00013600 162 
00013620 157 
00013640 162 
00013660 145 
00013670
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: od The od program labels Dec 27, 2023
@briandfoy briandfoy self-assigned this Dec 28, 2023
@briandfoy briandfoy merged commit c8ce01b into briandfoy:master Dec 28, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 29, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: od The od program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy