Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply: use library max() instead of hand-rolled #436

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 2, 2024

  • apply has a special mode where %NUM in the command string is substituted with an argument
  • %NUM can be repeated in the command string, and the highest number determines how many arguments are consumed
  • The explanation of this feature in the pod manual could be improved
  • This example takes 2 elements from ARGV per instance of echo command (example tested against OpenBSD version)
perl apply 'echo %1 %2' a*
a ab
ab.diff ab.diff.orig
ac.diff ac.diff.orig
ac.diff.Orig ac.diff.ORig
ac.diff.ORIg ac.diff.ORIG
a.col addbib
alink apply
apply.new ar
ar2 arch
arithmetic ar.unexpand.new
ar.unexpand.old ar.uu
asa asd
a.uniq awk

* apply has a special mode where %NUM in the command string is substituted with an argument
* %NUM can be repeated in the command string, and the highest number determines how many arguments are consumed
* The explanation of this feature in the pod manual could be improved
* This example takes 2 elements from ARGV per instance of echo command (example tested against OpenBSD version)

```
perl apply 'echo %1 %2' a*
a ab
ab.diff ab.diff.orig
ac.diff ac.diff.orig
ac.diff.Orig ac.diff.ORig
ac.diff.ORIg ac.diff.ORIG
a.col addbib
alink apply
apply.new ar
ar2 arch
arithmetic ar.unexpand.new
ar.unexpand.old ar.uu
asa asd
a.uniq awk
```
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: apply The apply program labels Feb 2, 2024
@briandfoy briandfoy merged commit 5c7c8d4 into briandfoy:master Feb 2, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Feb 2, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 2, 2024
@briandfoy
Copy link
Owner

changes: fix argument handling for %N handling

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: apply The apply program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants