Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: avoid divide by zero #626

Merged
merged 1 commit into from
May 29, 2024
Merged

expr: avoid divide by zero #626

merged 1 commit into from
May 29, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented May 29, 2024

  • Check for 0 before divide and modulo operations
  • Add newlines to die() to prevent line numbers appearing in "syntax error" messages

@mknos
expr: avoid divide by zero
0af48a0 
* Check for 0 before divide and modulo operations
* Add newlines to die() to prevent line numbers appearing in "syntax error" messages
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: expr The expr program labels May 29, 2024
@briandfoy briandfoy self-assigned this May 29, 2024
@briandfoy briandfoy merged commit 36ea1a3 into briandfoy:master May 29, 2024
2 checks passed
@briandfoy briandfoy added Type: bug an existing feature does not work Status: accepted The fix is accepted and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels May 29, 2024
@briandfoy
Copy link
Owner

changes: catch a divide-by-zero situation

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: expr The expr program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy