Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cal: unused variable #668

Merged
merged 1 commit into from
Jul 17, 2024
Merged

cal: unused variable #668

merged 1 commit into from
Jul 17, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 17, 2024 •
edited
Loading

  • $remain was unused in make_month_array()
  • perlcritic didn't find this one for me, possibly because of the assignment in the declaration statement

@mknos
cal: unused variable
1d88b0f 
* $remain was unused in fmt_month()
* perlcritic didn't find this one for me, possibly because of the assignment in the declaration statement
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cal The cal program labels Jul 17, 2024
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 17, 2024 08:54 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9971181344

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 9959948277: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy merged commit d1284b4 into briandfoy:master Jul 17, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jul 17, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jul 17, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cal The cal program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy