shar: uudecode problem

[mknos]

• For binary files, shar will construct input that is passed to the uudecode command
• When testing files from /bin on my Linux system, I saw decode errors when extracting with "sh new.shar"
• The file sizes didn't match
• When inspecting the output of shar from GNU sharutils, there was a terminating line with only a backtick immediately before the "end" line
• Adding the backtick line in this version makes uudecode work correctly; I tested this against a few files from my /bin
• binmode() isn't needed for STDOUT because shar always prints text output
• Convert FH to a regular variable
• The command line for decoding a binary file doesn't need a pipe through sed because the 'X' prefix letter is never added to the uuencoded data

%sh bash.shar  # before patch
x - bash
uudecode fatal error:
standard input: Short file
^C
%cmp bash /bin/bash 
cmp: EOF on /bin/bash after byte 974312, in line 14510

[coveralls]

Pull Request Test Coverage Report for Build 10033658436

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.7%) to 76.268%

---

Totals
Change from base Build 10026365693:	-0.7%
Covered Lines:	376
Relevant Lines:	493

---

💛 - Coveralls