Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tee: remove nonstandard -n option #683

Merged
merged 1 commit into from
Jul 26, 2024
Merged

tee: remove nonstandard -n option #683

merged 1 commit into from
Jul 26, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 26, 2024

  • There is no need to support -n, which is not provided by the BSD or GNU versions (nor AIX [1], Solaris)
  • Make some changes to prepare for enabling strict mode, e.g. add missing declaration for $status variable
  1. https://www.ibm.com/docs/en/aix/7.2?topic=t-tee-command

@mknos
tee: remove nonstandard -n option
3df1c64 
* There is no need to support -n, which is not provided by the BSD or GNU versions (nor AIX [1], Solaris)
* Make some changes to prepare for enabling strict mode, e.g. add missing declaration for $status variable

1. https://www.ibm.com/docs/en/aix/7.2?topic=t-tee-command
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tee The tee program labels Jul 26, 2024
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 26, 2024 03:21 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10105155983

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10096476958: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

briandfoy
briandfoy approved these changes Jul 26, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, on macOS the -n is a completely different thing for nonseekable files.

@briandfoy briandfoy merged commit 21fd9b4 into briandfoy:master Jul 26, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jul 26, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Jul 26, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jul 26, 2024
@briandfoy
Copy link
Owner

changes: remove non-standard -n, which suppressed standard output.

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tee The tee program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy