Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

true/false: ignore options #693

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 1, 2024

  • Standards document says that true does not handle options [1]
  • No reference to options in the solaris manual either [2]
  • I tested 4 versions of true and only the GNU version handles options
  • test1: /bin/true --version # gnu version on linux
  • test2: builtin true --version # bash builtin on linux
  • test3: /usr/bin/true --version # openbsd version
  • test4: builtin true --version # ksh builtin on openbsd
  • The same is true for false
  1. https://pubs.opengroup.org/onlinepubs/009695399/utilities/true.html
  2. https://shrubbery.net/solaris9ab/SUNWaman/hman1/true.1.html

mknos added 2 commits August 1, 2024 19:05
* Standards document says that true does not handle options [1]
* No reference to options in the solaris manual either [2]
* I tested 4 versions of true and only the GNU version handles options
* test1: /bin/true --version # gnu version on linux
* test2: builtin true --version # bash builtin on linux
* test3: /usr/bin/true --version # openbsd version
* test4: builtin true --version # ksh builtin on openbsd

1. https://pubs.opengroup.org/onlinepubs/009695399/utilities/true.html
2. https://shrubbery.net/solaris9ab/SUNWaman/hman1/true.1.html
* Following GNU behaviour is not required or desirable when it comes to option handling
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: true The true program labels Aug 1, 2024
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@github-actions github-actions bot added the Program: false The false program label Aug 1, 2024
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 11:11 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 10197176138

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%

Totals Coverage Status
Change from base Build 10176256664: -0.7%
Covered Lines: 376
Relevant Lines: 493

💛 - Coveralls

Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I once asked an internal to write me a login shell that would simply output a message saying that the account is restricted and then exit. He delivered three or four screens of code after a month of trying. I then showed him something like this:

printf( stdout, .... );
exit(1);

@briandfoy briandfoy self-assigned this Aug 2, 2024
@briandfoy briandfoy merged commit fb1f46c into briandfoy:master Aug 2, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 2, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: false The false program Program: true The true program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants