patch: -o filename versus directory #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Aug 6, 2024
mknos
commented
- The "-o file" option is a standard feature of patch
- When I tested -o with a directory argument the directory was replaced with the patched file
- After the initial panic that patch had destroyed the directory, I discovered that it only renamed it to thing.orig
- A directory is not a valid argument for -o; raise an error instead of processing the patch
- This was found when testing against GNU patch
* The "-o file" option is a standard feature of patch * When I tested -o with a directory argument the directory was replaced with the patched file * After the initial panic that patch had destroyed the directory, I discovered that it only renamed it to thing.orig * A directory is not a valid argument for -o; raise an error instead of processing the patch * This was found when testing against GNU patch
github-actions
bot
added
Type: enhancement
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
approved these changes
Aug 6, 2024
briandfoy
approved these changes
Aug 6, 2024
|
changes: -o complains if its argument is a directory |
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.