Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: simplify --check #706

Merged
merged 2 commits into from
Aug 8, 2024
Merged

patch: simplify --check #706

merged 2 commits into from
Aug 8, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 8, 2024

  • "patch --check" can be implemented in less code using File::Temp to provide a garbage filehandle which is automatically cleaned up later
  • I tested this by repeatedly running "perl patch -C original.c my.diff"; original.c is not modified so each instance is successful
  • For --check mode there is no need for o_fh and d_fh to be a different filehandle because data written to it is discarded anyway

mknos added 2 commits August 8, 2024 16:24
@mknos
patch: simpler --check code
3fe41da 
* "patch --check" can be implemented in less code using File::Temp to provide a garbage filehandle which is automatically cleaned up later
* I tested this by repeatedly running "perl patch -C original.c my.diff"; original.c is not modified so each instance is successful
@mknos
no need for o_fh & o_dh to be a different file
872e4a1
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: patch The patch program labels Aug 8, 2024
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 08:32 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10298700713

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 73.375%
Files with Coverage Reduction New Missed Lines %
bin/units 3 71.21%
Totals Coverage Status
Change from base Build 10284007665: -0.7%
Covered Lines: 350
Relevant Lines: 477
💛 - Coveralls

@briandfoy briandfoy merged commit 4239cb9 into briandfoy:master Aug 8, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Aug 8, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Aug 8, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Aug 8, 2024
@briandfoy
Copy link
Owner

changes: use File::Temp to get the /dev/null filehandle

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: patch The patch program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy