-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dirname: support -- terminator #716
Conversation
mknos
commented
Aug 13, 2024
- Standards document has an example where "--" option terminator is used.. $(dirname -- file) [1]
- dirname is not a bash builtin on my Linux system
- GNU and OpenBSD dirname support "--" so add it here too
- GNU version supports multiple path arguments, but that does not follow the standard (this version already raised an error for multiple arguments)
- test1: "perl dirname -- $(pwd)/A" --> single file argument after -- is valid
- test2: "perl dirname a b" --> too many args
- test3: "perl dirname --" --> not enough args
- test4: "perl dirname -x -- -A" --> bad option error
- https://pubs.opengroup.org/onlinepubs/9699919799/utilities/dirname.html
* Standards document has an example where "--" option terminator is used.. $(dirname -- file) [1] * dirname is not a bash builtin on my Linux system * GNU and OpenBSD dirname support "--" so add it here too * GNU version supports multiple path arguments, but that does not follow the standard (this version already raised an error for multiple arguments) 1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/dirname.html
Pull Request Test Coverage Report for Build 10407089446Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you've completely replaced the program, you should get credit in the metadata