Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: retire study() #739

Merged
merged 1 commit into from
Sep 20, 2024
Merged

grep: retire study() #739

merged 1 commit into from
Sep 20, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 20, 2024

  • Current perl treats study() call as no-op so delete it [1]
  • grep was the only caller of study(); no other scripts need updating
  • While here, convert a "use" statement within a condition to a "require" (found by perlcritic)
  • Regression test: "perl grep -Hn include a.c b.c" --> still highlights the matching part of each line on my Linux system
  1. https://perldoc.perl.org/functions/study

@mknos
grep: retire study()
3e52b3b 
* Current perl treats study() call as no-op so delete it [1]
* grep was the only caller of study(); no other scripts need updating
* While here, convert a "use" statement within a condition to a "require" (found by perlcritic)
* Regression test: "perl grep -Hn include a.c b.c" --> still highlights the matching part of each line on my Linux system

1. https://perldoc.perl.org/functions/study
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Sep 20, 2024
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 20, 2024 10:56 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Sep 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10957973451

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10953975344: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Sep 20, 2024
briandfoy
briandfoy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh - https://stackoverflow.com/questions/8383527/which-situations-benefit-from-perls-study

@briandfoy briandfoy merged commit 5bae87a into briandfoy:master Sep 20, 2024
21 of 23 checks passed
@briandfoy briandfoy added Type: modernization updating programs to current practices and removed Type: enhancement improve a feature that already exists labels Sep 20, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Sep 20, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: modernization updating programs to current practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy