-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grep: implement -x for fixed strings #742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Sep 23, 2024
- Standards document mentions that option -x should work with fixed strings [1]
- This version didn't allow -x with -F; add it now for better compliance with standard
- I have a small test file with some C code
- test1: "perl grep int a.c" --> matches "int\n" and "printf(...);\n"
- test2: "perl grep -i Int a.c" --> same match as test1
- test3: "perl grep -iv Int a.c" --> matches all except "int\n" and "printf(...);\n"
- test4: "perl grep -v Int a.c" --> matches all lines because Int doesn't appear at all
- test5: "perl grep -F -x int a.c" --> matches only "int\n"
- test6: "perl grep -Fxi Int a.c" --> same match as test5
- test7: "perl grep -Fxiv Int a.c" --> matches all except "int\n"
- test8: "perl grep -Fxv Int a.c" --> matches all lines because Int doesn't appear at all
- https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html
* Standards document mentions that option -x should work with fixed strings [1] * This version didn't allow -x with -F; add it now for better compliance with standard * I have a small test file with some C code * test1: "perl grep int a.c" --> matches "int\n" and "printf(...);\n" * test2: "perl grep -i Int a.c" --> same match as test1 * test3: "perl grep -iv Int a.c" --> matches all except "int\n" and "printf(...);\n" * test4: "perl grep -v Int a.c" --> matches all lines because Int doesn't appear at all * test5: "perl grep -F -x int a.c" --> matches only "int\n" * test6: "perl grep -Fxi Int a.c" --> same match as test5 * test7: "perl grep -Fxiv Int a.c" --> matches all except "int\n" * test8: "perl grep -Fxv Int a.c" --> matches all lines because Int doesn't appear at all 1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: grep
The grep program
labels
Sep 23, 2024
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
September 23, 2024 13:45 — with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 10995604813Details
💛 - Coveralls |
briandfoy
approved these changes
Sep 23, 2024
briandfoy
added
Status: accepted
The fix is accepted
and removed
Priority: low
get to this whenever
labels
Sep 23, 2024
briandfoy
added
Status: released
there is a new release with this fix
and removed
Status: accepted
The fix is accepted
labels
Sep 30, 2024
briandfoy
added
Type: compatability
make it work like GNU or BSD
and removed
Type: enhancement
improve a feature that already exists
labels
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: grep
The grep program
Status: released
there is a new release with this fix
Type: compatability
make it work like GNU or BSD
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.