Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: support % for all-addresses #782

Merged
merged 1 commit into from
Nov 5, 2024
Merged

ed: support % for all-addresses #782

merged 1 commit into from
Nov 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 5, 2024

  • GNU ed treats '%' as an alias for ',' and allows it to be used either alone or as a delimiter between addresses
  • OpenBSD ed only allows '%' to be used alone, with the meaning of "all addresses"
  • Go with the BSD meaning of '%' and implement lone-percent prefix in command parser
  • test1: %n ---> same as ,n
  • test2: %s/float/double/ ---> perform one substitution per line for all lines in editor buffer
  • test3: 1%2p ---> invalid
  • test4: 1%p ---> invalid
  • test5: %2p ---> invalid

@mknos
ed: support % for all-addresses
0cb28a0 
* GNU ed treats '%' as an alias for ',' and allows it to be used alone or as a delimiter between addresses
* OpenBSD ed only allows '%' to be used alone,  with the meaning of all-addresses
* Go with the BSD meaning of '%' and implement lone-percent address prefix in command parser
* test1: %n ---> same as ,n
* test2: %s/float/double/ ---> perform one substitution per line for all lines in editor buffer
* test3: 1%2p ---> invalid
* test4: 1%p ---> invalid
* test5: %2p ---> invalid
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos had a problem deploying to automated_testing November 5, 2024 07:19 — with GitHub Actions Failure
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@github-actions github-actions bot added the Type: enhancement improve a feature that already exists label Nov 5, 2024
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@github-actions github-actions bot added Priority: low get to this whenever Program: ed The ed program labels Nov 5, 2024
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:20 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11679355610

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11675735372: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 5, 2024
@mknos mknos temporarily deployed to automated_testing November 5, 2024 07:41 — with GitHub Actions Inactive
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 5, 2024
@briandfoy
Copy link
Owner

changes: % takes OpenBSD meaning of "all addresses"; it can only be used alone

@briandfoy briandfoy merged commit 92ea33d into briandfoy:master Nov 5, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy