Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wump: unused variable #802

Merged
merged 1 commit into from
Nov 12, 2024
Merged

wump: unused variable #802

merged 1 commit into from
Nov 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 12, 2024

  • Global list @P is not required; @P is declared locally within shoot() --- this was found by perlcritic
  • Remove unhelpful comments at end of file
  • Factor shoot_or_move() prompt function so there's one statement per line, and one return statement
  • Maintaining the BASIC code comments is impossible

@mknos
wump: unused variable
71f4759 
* Global list P is not required; P is declared locally within shoot() --- this was found by perlcritic
* Remove unhelpful comments at the end of file
* Factor shoot_or_move() prompt function so there's one statement per line, and one return statement
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Nov 12, 2024
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@github-actions github-actions bot added the Program: wump The wump program label Nov 12, 2024
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 05:06 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11791080505

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11774186393: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 12, 2024
@briandfoy briandfoy merged commit d462a62 into briandfoy:master Nov 12, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: wump The wump program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy