Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail: add strict #825

Merged
merged 2 commits into from
Nov 19, 2024
Merged

mail: add strict #825

merged 2 commits into from
Nov 19, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 19, 2024

  • The message about "strict" in the BUGS section of the manual was a reminder to make this change
  • Do mechanically with set/get functions what was being done with AUTOLOAD
  • Attribute "status" in object "message" was never used
  • Attribute "append" in object "mailbox" was never used
  • Many local variables were not declared before use
  • No-strict had allowed list-deref of undef in replyCC()
  • Bump version
%RELAYHOST=localhost perl mail  -f mbox # initial test (connect error is expected)
Loading the mailfile mbox
Mail [0.04 Perl] [linux]
 N  1                                      0/ 808 (no subject)
    2           nobody  Mon Sep 17 00:00   0/1036 [PATCH] another patch
    3           nobody  Mon Sep 17 00:00   0/ 706 re: [PATCH] another patch
    4           nobody  Sat Aug 27 23:07   0/3138 [PATCH 1/2] GIT: Try all addr
    5           nobody  Sat Aug 27 23:07   0/3764 [PATCH] Fixed two bugs in git
    6           nobody  Mon Sep 17 00:00   0/2926 [PATCH] a commit.
    7           nobody  Mon Sep 17 00:00   0/ 194 [PATCH] another patch
    8           nobody  Mon Sep 17 00:00   0/ 297 re: [PATCH] another patch
    9           nobody  Mon Sep 17 00:00   0/ 866 (no subject)
   10 b9704a518e211584  Mon Sep 17 00:00   0/1214 Re: discussion that lead to t
   11           nobody  Fri Aug  8 22:24   0/ 905 [PATCH 3/3 v2] Xyzzy
   12    bda@mnsspb.ru  Wed Nov 12 17:54   0/1727 [Navy-patches] [PATCH]	=?utf-
   13           nobody  Mon Sep 17 00:00   0/ 152 [PATCH] a patch
   14           nobody  Mon Sep 17 00:00   0/2363 Why doesn't git-am does not l
   15           nobody  Mon Sep 17 00:00   0/ 304 check bogus body header (from
   16           nobody  Mon Sep 17 00:00   0/ 296 check bogus body header (date
> 300
Invalid message number: 300
> 8
Message: 8
From nobody Mon Sep 17 00:00:00 2001
From: Junio C Hamano <junio@kernel.org>
Date: Fri, 9 Jun 2006 00:44:16 -0700
Subject: re: [PATCH] another patch

From: A U Thor <a.u.thor@example.com>
Subject: [PATCH] another patch
>Here is an empty patch from A U Thor.

Hey you forgot the patch!

> r
To: nobody
Subject: re: [PATCH] another patch
reply123
.
Unable to connect to the specified relay host
IO::Socket::INET: connect: Connection refused

* The message about "strict" in the BUGS section of the manual was a reminder to make this change
* Do mechanically with set/get functions what was being done with AUTOLOAD
* Attribute "status" in object "message" was never used
* Attribute "append" in object "mailbox" was never used
* Many local variables were not declared before use
* Bump version
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mail The mail program labels Nov 19, 2024
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 13:16 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 11913848776

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%

Totals Coverage Status
Change from base Build 11910111793: 0.0%
Covered Lines: 350
Relevant Lines: 479

💛 - Coveralls

@briandfoy briandfoy merged commit a70b742 into briandfoy:master Nov 19, 2024
23 checks passed
@briandfoy briandfoy self-assigned this Nov 19, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: modernization updating programs to current practices and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Nov 19, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: mail The mail program Status: released there is a new release with this fix Type: modernization updating programs to current practices
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants