Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: implement -b flag #839

Merged
merged 1 commit into from
Nov 26, 2024
Merged

install: implement -b flag #839

merged 1 commit into from
Nov 26, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 26, 2024

  • The install command doesn't have an equivalent of cp's no-clobber (-n) flag to preserve existing files
  • Running "install -C ..." will preserve and existing file if it's identical to the file being copied
  • This patch adds -b, which preserves an existing file by renaming it to $YOURNAMEHERE.old
  • If the rename() fails, the file should not be copied because that would clobber it

@mknos
install: implement -b flag
94c03bd 
* The install command doesn't have an equivalent of cp's no-clobber (-n) flag to preserve existing files
* Running "install -C ..." will preserve and existing file if it's identical to the file being copied
* This patch adds -b, which preserves an existing file by renaming it to $YOURNAMEHERE.old
* If the rename() fails, the file should not be copied because that would clobber it
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: install The install program labels Nov 26, 2024
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 26, 2024 04:37 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12023912207

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 12016871827: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 26, 2024
@briandfoy briandfoy merged commit a6d8f86 into briandfoy:master Nov 26, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: implement -b to preserve existing files

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 26, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: install The install program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy