Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

units: allow -fFILE #844

Merged
merged 2 commits into from
Nov 30, 2024
Merged

units: allow -fFILE #844

merged 2 commits into from
Nov 30, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 29, 2024 •
edited
Loading

  • BSD version allows FILE argument to -f option with and without a space
  • Remove --file option because it is not a standard thing (DragonFlyBSD, NetBSD & OpenBSD don't have it)
  • Previously the regex for -f option would allow bare '-' but now that is treated as an invalid option
  • Also allow '--' to terminate options (found when testing against OpenBSD)

@mknos
units: allow -fFILE
7720bfa 
* BSD version allows FILE argument to -f option with and without a space
* Remove --file option because it is not a standard thing (DragonFlyBSD, NetBSD & OpenBSD don't have it)
* Previously the regex for -f option would allow bare '-' but now that is treated as an invalid option
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: units The units program labels Nov 29, 2024
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 03:49 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12078975083

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 72.464%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bin/units 0 6 0.0%
Totals Coverage Status
Change from base Build 12070185097: -0.6%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 04:25 — with GitHub Actions Inactive
@briandfoy briandfoy self-assigned this Nov 30, 2024
@briandfoy briandfoy merged commit ad1b3b9 into briandfoy:master Nov 30, 2024
21 of 22 checks passed
@briandfoy
Copy link
Owner

changes: allow -fFILE (no space before argument)

@briandfoy briandfoy added Type: compatability make it work like GNU or BSD Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 30, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: units The units program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy