Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexdump: common duplicate line check #851

Merged
merged 1 commit into from
Dec 3, 2024
Merged

hexdump: common duplicate line check #851

merged 1 commit into from
Dec 3, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 3, 2024 •
edited
Loading

  • Move repeated code for the -v option up a level, from the individual formatter functions into dofile()
  • The saved string $prev can't be declared in dofile() because dofile() will be called again for the first line of the next file (hexdump sees them as one joined file)

@mknos
hexdump: common duplicate line check
628184f 
* Move repeated code for -v the option up a level, from the individual formatter functions into dofile()
* The saved string $prev can't be declared in dofile() because dofile() will be called again for the first line of the next file (hexdump sees them as one joined file)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: hexdump The hexdump program labels Dec 3, 2024
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:08 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12130253695

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12128359092: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 3, 2024
@briandfoy briandfoy merged commit bd18cdf into briandfoy:master Dec 3, 2024
22 of 23 checks passed
@briandfoy briandfoy added the Status: accepted The fix is accepted label Dec 3, 2024
@briandfoy briandfoy removed the Type: enhancement improve a feature that already exists label Dec 3, 2024
@briandfoy briandfoy added Type: modernization updating programs to current practices Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: hexdump The hexdump program Status: released there is a new release with this fix Type: modernization updating programs to current practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy