Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

od: remove global $len #852

Merged
merged 1 commit into from
Dec 3, 2024
Merged

od: remove global $len #852

merged 1 commit into from
Dec 3, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 3, 2024

  • perlcritic issued a warning that the variable $len in zeropad() was aliasing a global variable
  • I found that $len doesn't need to be a global
  • dump_file() and do_skip() save the read() return value into $len
  • Beyond checking for a failed read, the value of $len was not needed

@mknos
od: remove global $len
8b1c843 
* perlcritic issued a warning that the variable $len in zeropad() was aliasing a global variable
* I found that $len doesn't need to be a global
* dump_file() and do_skip() save the read() return value into $len
* Beyond checking for a failed read, the value of $len was not needed
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: od The od program labels Dec 3, 2024
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 00:45 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12130695411

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12128359092: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 3, 2024
@briandfoy briandfoy merged commit bc6afa9 into briandfoy:master Dec 3, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

I don't particularly care for perlcritic, but if you'd like to add a perlcriticrc that you like, we can start applying it. I figure that most programs will fail horribly. :)

@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: od The od program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy