Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glob: remove function prototypes #859

Merged
merged 1 commit into from
Dec 5, 2024
Merged

glob: remove function prototypes #859

merged 1 commit into from
Dec 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 5, 2024

  • When temporarily enabling warnings.pm, glob prints a warning: FastGlob::explode_glob() called too early to check prototype
  • Remove the prototypes to silence the warning
  • I didn't notice any other warnings when testing some glob inputs

@mknos
glob: remove function prototypes
55f7bae 
* When temporarily enabling warnings.pm, glob prints a warning: FastGlob::explode_glob() called too early to check prototype
* Remove the prototypes to silence the warning
* I didn't notice any other warnings when testing some glob inputs
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: glob The glob program labels Dec 5, 2024
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 06:16 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12174287024

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12157171498: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 5, 2024
@briandfoy briandfoy merged commit fbfdc39 into briandfoy:master Dec 5, 2024
22 of 23 checks passed
@briandfoy briandfoy removed the Priority: low get to this whenever label Dec 5, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Dec 5, 2024
@briandfoy
Copy link
Owner

changes: silence some warnings by removing prototypes

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: glob The glob program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy