Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: add undo feature #869

Merged
merged 1 commit into from
Dec 9, 2024
Merged

ed: add undo feature #869

merged 1 commit into from
Dec 9, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 9, 2024

  • The undo command (u) was listed in a TODO comment
  • There's only 1 level of undo, i.e undo will undo itself
  • This implementation which assumes /tmp has enough space to store a copy of the buffer
  • Write a new undo buffer if a modification was detected
  • According to other versions, the current line pointer should be updated too, but I want to handle this later
  • Remove some ancient comments; perl coolness is a guiding principle
  • Document undo in POD

@mknos
ed: add undo feature
9b5e19f 
* The undo command (u) was listed in a TODO comment
* There's only 1 level of undo, i.e undo will undo itself
* This implementation which assumes /tmp has enough space to store a copy of the buffer
* Write a new undo buffer if a modification was detected
* According to other versions, the current line pointer should be updated too, but I want to handle this later
* Remove some ancient comments; perl coolness *is* a guiding principle
* Document undo in POD
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Dec 9, 2024
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 04:24 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12228913072

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12203109856: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit eda9dca into briandfoy:master Dec 9, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: add undo (u) command

@briandfoy briandfoy self-assigned this Dec 9, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy