Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paste: factor loop #898

Merged
merged 1 commit into from
Jan 3, 2025
Merged

paste: factor loop #898

merged 1 commit into from
Jan 3, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 3, 2025

  • The input loop was written as a forever loop with an eof check at the top of loop body
  • Convert the eof check to a function so the loop can be written as a "while"
  • Also add --version as done in other scripts
  • Regression test: perl paste /etc/motd /etc/motd

@mknos
paste: factor loop
7de1790 
* The input loop was written as a forever loop with an eof check at the top of loop body
* Convert the eof check to a function so the loop can be written as a "while"
* Also add --version as done in other scripts
* Regression test: perl paste /etc/motd /etc/motd
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:48 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: paste The paste command labels Jan 3, 2025
@coveralls
Copy link

coveralls commented Jan 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12591445544

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12591369585: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:33 — with GitHub Actions Inactive
@briandfoy briandfoy merged commit 9df8833 into briandfoy:master Jan 3, 2025
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jan 3, 2025
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 3, 2025
@briandfoy
Copy link
Owner

changes: add --version; light refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: paste The paste command Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy