Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rmdir: replace dirname() loop #911

Merged
merged 2 commits into from
Jan 7, 2025
Merged

rmdir: replace dirname() loop #911

merged 2 commits into from
Jan 7, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 7, 2025

  • In -p mode, split a directory argument with File::Spec (based on a recent change to mkdir)
  • The final element of the split is ignored because that directory has already been handled by the unconditional remove()
  • The '/' directory will not be removed if an absolute path is given on u***nix
  • test1: perl rmdir -p A/B/C # relative path
  • test2: perl rmdir -p /a/b/c # absolute path

mknos added 2 commits January 7, 2025 11:09
@mknos
rmdir: replace dirname() loop
2f71919 
* In -p mode, split a directory argument with File::Spec as recently done in mkdir
* The final element of the split is ignored because that directory has already been removed by the unconditional remove()
* The '/' directory will not be removed if an absolute path is given on u***nix
* test1: perl rmdir -p A/B/C # relative path
* test2: perl rmdir -p /a/b/c # absolute path
@mknos
remove stray variable
ba7181e
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: rmdir The rmdir program labels Jan 7, 2025
@mknos mknos had a problem deploying to automated_testing January 7, 2025 03:15 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing January 7, 2025 03:15 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing January 7, 2025 03:15 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing January 7, 2025 03:15 — with GitHub Actions Failure
@briandfoy briandfoy self-assigned this Jan 7, 2025
@briandfoy briandfoy added Type: modernization updating programs to current practices and removed Type: enhancement improve a feature that already exists labels Jan 7, 2025
@briandfoy briandfoy merged commit 14d8a63 into briandfoy:master Jan 7, 2025
1 of 22 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: rmdir The rmdir program Status: accepted The fix is accepted Type: modernization updating programs to current practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy