-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed: avoid literal newline in s/// #917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Jan 9, 2025
- Yesterday when editing a file I discovered the escape sequence "\n" was expanded to a newline when used in a substitution command
- This has the unintended result of updating one or more elements of the lines-list to contain multiple newline characters
- GNU and OpenBSD versions treat "\n" as a regular "n"; follow this for compatibility, and to avoid the problem of line x containing many lines
* Yesterday when editing a file I discovered the escape sequence "\n" was expanded to a newline when used in a substitution command * This has the unintended result of updating one or more elements of the lines-list to contain multiple newline characters * GNU and OpenBSD versions treat "\n" as a regular "n"; follow this for compatibility, and to avoid the problem of line x containing many lines
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: ed
The ed program
labels
Jan 9, 2025
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:44 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
January 9, 2025 02:45 — with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 12682668341Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12682668342Details
💛 - Coveralls |
briandfoy
approved these changes
Jan 9, 2025
briandfoy
added
Type: bug
an existing feature does not work
Status: accepted
The fix is accepted
and removed
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
labels
Jan 9, 2025
changes: \n in a substitution is now just a literal n, not a newline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: ed
The ed program
Status: accepted
The fix is accepted
Type: bug
an existing feature does not work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.