Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duration called on null for cupertino controls #406

Merged

Conversation

DFelten
Copy link
Contributor

@DFelten DFelten commented Nov 25, 2020

Fixes the duration is called on null error which appears when showing videos with cupertino controls.

Associated tickets:

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 26, 2020

@nstrelow I think here're just the current dart sdk constraints missing (>2.20). Shell we update this, rebase and merge after checks succeeded?

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 26, 2020

I could also just update the missing null check

@nstrelow
Copy link
Collaborator

This should be failing on the master branch as well right?

If the failed checks are not related to changed code, I would just merge this PR and fix the linting on the master branch.

@nstrelow nstrelow force-pushed the bugfix/duration-called-on-null branch from 16fba6f to 9b88eb8 Compare November 27, 2020 11:02
@nstrelow nstrelow merged commit 80b070d into fluttercommunity:master Nov 27, 2020
@noinskit
Copy link

Hi, I'm also experiencing this problem. Could you please release a version with this fix?

@nstrelow
Copy link
Collaborator

@Ahmadre Do you have the time to release a version?

Or @brianegan Could you allow me to releasse versions as well? :)

@Ahmadre
Copy link
Collaborator

Ahmadre commented Dec 29, 2020

@Ahmadre Do you have the time to release a version?

Or @brianegan Could you allow me to releasse versions as well? :)

Definitely! Can I give you also the rights? Otherwise I'll release a version in the late evening today :)

@nstrelow
Copy link
Collaborator

If you can, my pub.dev email is strelow.nils@gmail.com

@mohamedshanan
Copy link

Thanks guys, hope you release this soon.

@nstrelow
Copy link
Collaborator

@Ahmadre Bumping, sorry to bother you, but people are in need of a fix :)

@Ahmadre
Copy link
Collaborator

Ahmadre commented Dec 31, 2020

@Ahmadre Bumping, sorry to bother you, but people are in need of a fix :)

I invited you right now :). Have a look into your mails.

@nstrelow
Copy link
Collaborator

nstrelow commented Jan 2, 2021

Fix was release now. Please check if it works now

@DFelten DFelten deleted the bugfix/duration-called-on-null branch January 2, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants