-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duration called on null for cupertino controls #406
Fix duration called on null for cupertino controls #406
Conversation
@nstrelow I think here're just the current dart sdk constraints missing (>2.20). Shell we update this, rebase and merge after checks succeeded? |
I could also just update the missing null check |
This should be failing on the master branch as well right? If the failed checks are not related to changed code, I would just merge this PR and fix the linting on the master branch. |
16fba6f
to
9b88eb8
Compare
Hi, I'm also experiencing this problem. Could you please release a version with this fix? |
@Ahmadre Do you have the time to release a version? Or @brianegan Could you allow me to releasse versions as well? :) |
Definitely! Can I give you also the rights? Otherwise I'll release a version in the late evening today :) |
If you can, my pub.dev email is strelow.nils@gmail.com |
Thanks guys, hope you release this soon. |
@Ahmadre Bumping, sorry to bother you, but people are in need of a fix :) |
I invited you right now :). Have a look into your mails. |
Fix was release now. Please check if it works now |
Fixes the duration is called on null error which appears when showing videos with cupertino controls.
Associated tickets: