Skip to content

Commit

Permalink
Fix duration called on null for cupertino controls
Browse files Browse the repository at this point in the history
  • Loading branch information
DFelten authored and nstrelow committed Nov 27, 2020
1 parent fe5de1e commit 80b070d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/src/cupertino_controls.dart
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class _CupertinoControlsState extends State<CupertinoControls> with SingleTicker
}

Expanded _buildHitArea() {
final bool isFinished = _latestValue.position >= _latestValue.duration;
final bool isFinished = _latestValue.duration != null && _latestValue.position >= _latestValue.duration;

return Expanded(
child: GestureDetector(
Expand Down

5 comments on commit 80b070d

@mahmoudalaa97
Copy link

@mahmoudalaa97 mahmoudalaa97 commented on 80b070d Nov 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did You Update this plugin after you fix it or not yet? because in version chewie: ^0.12.0 i have same issues

@nstrelow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin was not updated yet.
@Ahmadre could you do that please?
Or give me instructions on how to do it? I should look up how to automate this some time.

@mahmoudalaa97
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm Waiting for This Update 🤟

@mahmoudalaa97
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ahmadre
@nstrelow
Any Updated Version For This Issues ??

@nstrelow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ahmadre Could you release a new version?
Or can you give me access to do it?

Please sign in to comment.