Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Apache Crail (Incubating) #1266

Merged
merged 7 commits into from
Jun 1, 2019

Conversation

patrickstuedi
Copy link
Contributor

No description provided.

@patrickstuedi
Copy link
Contributor Author

@busbey Sean, this is an updated PR integrating Crail (crail.apache.org) we discussed last year. Do you think the PR will be merged soon, or are there an missing pieces or issues you would like me to address?

Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is real close.

  • Move classes into a crail specific package
  • Make binding respect configuration of table name
  • Use a logging framework instead of System.out

That said, this has been a long time coming so I might just push a commit with the needed changes if I get some time.

@patrickstuedi
Copy link
Contributor Author

Ok, thanks, I'll should have this ready next week!

@patrickstuedi
Copy link
Contributor Author

The PR is ready for review.

  • Moved the classes to a crail specific package
  • Setting table based on properties
  • Using logging framework instead of System.out
  • Also added one new parameter to control whether or not the keys can be enumerated

@busbey busbey merged commit 1b6e858 into brianfrankcooper:master Jun 1, 2019
@busbey
Copy link
Collaborator

busbey commented Jun 1, 2019

Thanks for pushing on this again @patrickstuedi

I'll ping you for testing when the next release gets going.

@busbey busbey mentioned this pull request Jun 4, 2019
@busbey busbey mentioned this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants