Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing the driver and fixing update #1298

Merged
merged 2 commits into from
Apr 20, 2019
Merged

Optimizing the driver and fixing update #1298

merged 2 commits into from
Apr 20, 2019

Conversation

voellm
Copy link
Contributor

@voellm voellm commented Apr 20, 2019

Optimizing the driver and fixing the update code which was clobbering rather than updating.

Optimizing the driver to remove unneeded work and
Copy link
Collaborator

@stfeng2 stfeng2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR was already reviewed in 1297, this is simply a new one that incorporates all comments from that one.

LGTM.

@stfeng2 stfeng2 merged commit 0397cb6 into brianfrankcooper:master Apr 20, 2019
@busbey busbey mentioned this pull request Jun 4, 2019
@busbey busbey mentioned this pull request Sep 21, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants