Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small screen overflowing issue #2026

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Conversation

B-Mustafa
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 18, 2024

@B-Mustafa is attempting to deploy a commit to the Brian Lovin Team on Vercel.

A member of the Team first needs to authorize it.

@B-Mustafa
Copy link
Contributor Author

#2024

fixed this issue

Copy link
Owner

@brianlovin brianlovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this! Is there a reason for adding extra spaces around some of the class names?

@B-Mustafa
Copy link
Contributor Author

No , not really , i was checking out and might have left out left whitespaces

@B-Mustafa
Copy link
Contributor Author

B-Mustafa commented Apr 30, 2024

Any updates on it @brianlovin ?

@B-Mustafa
Copy link
Contributor Author

hey @brianlovin , any updates regarding this PR ?

@brianlovin
Copy link
Owner

@B-Mustafa — could you push a change to clear out the unneeded space characters in the diff? Thank you!

@B-Mustafa
Copy link
Contributor Author

Alright i will push a new changes one without extra spaces !

@B-Mustafa
Copy link
Contributor Author

@brianlovin did the latest commit with all the necessary changes
small screen

@B-Mustafa
Copy link
Contributor Author

@brianlovin any updates ?

@brianlovin brianlovin merged commit 1465797 into brianlovin:main Jun 14, 2024
3 of 4 checks passed
@brianlovin
Copy link
Owner

Merged @B-Mustafa — thank you!

@brianlovin
Copy link
Owner

Needed to revert, but fixed the responsiveness and typography in later commits! Thanks again for the nudge.

@B-Mustafa
Copy link
Contributor Author

@brianlovin alright brian Thanks for the Update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants