-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for macos #180
Add CI for macos #180
Conversation
C++ compilation failed without these explicit casts.
Now that a C++ compiler is used to support later versions of ICU, we need to surround all C code with `extern "C"` to avoid name mangling that would cause issues with symbol resolution on macOS.
@@ -0,0 +1,27 @@ | |||
name: CI | |||
|
|||
on: [push, pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on: [push, pull_request] | |
on: | |
push: | |
branches: | |
- main | |
pull_request: | |
branches: | |
- main |
Saw your post on mastodon. Thought this might help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... nevermind, I misread, sorry. 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe found part of the problem
|
||
jobs: | ||
test: | ||
runs-on: ${{ matrix.os }}-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem is here... macos-14-latest doesn't make sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's what I get for copy/pasting YAML files. I wish GitHub would tell me the "runs-on" doesn't make sense.
* stanhu-sh-auto-detect-cxx-flags: Avoid C++ name mangling in C code Fix C pointer conversion errors Auto-detect C++ extensions needed to build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearing request for changes
No description provided.