Add CI for macos #180
Merged
Add CI for macos #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ compilation failed without these explicit casts.
Now that a C++ compiler is used to support later versions of ICU, we need to surround all C code with `extern "C"` to avoid name mangling that would cause issues with symbol resolution on macOS.
SeanKilleen
reviewed
Jul 9, 2024
| @@ -0,0 +1,27 @@ | |||
| name: CI | |||
|
|
|||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
Suggested change
| on: [push, pull_request] | |
| on: | |
| push: | |
| branches: | |
| - main | |
| pull_request: | |
| branches: | |
| - main |
Saw your post on mastodon. Thought this might help?
There was a problem hiding this comment.
... nevermind, I misread, sorry. 🤦♂️
zenspider
suggested changes
Jul 9, 2024
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ${{ matrix.os }}-latest |
There was a problem hiding this comment.
I think the problem is here... macos-14-latest doesn't make sense to me
There was a problem hiding this comment.
Yep, that's what I get for copy/pasting YAML files. I wish GitHub would tell me the "runs-on" doesn't make sense.
* stanhu-sh-auto-detect-cxx-flags: Avoid C++ name mangling in C code Fix C pointer conversion errors Auto-detect C++ extensions needed to build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.