Translation #22

bnoufel · 2017-01-15T19:09:14Z

Finish to translate en to fr

Translate en to chinese thanks to Zhilian DAI :) 👍

brianmichel · 2017-01-19T14:16:56Z

@flayor sorry I must have missed the email for this PR! I'll take a look when I get home from work today.

bnoufel · 2017-01-19T16:23:17Z

no problem again, take your time :)

For the bug how you tell you 2-3 weeks ago, i don't know if you see but i resolved that you can read this issue #21

brianmichel

Overall looks great! Just a few small changes requested.

brianmichel · 2017-01-21T15:21:49Z

Juice/Classes/zh-Hans.lproj/GeneralPreferencesViewController.strings

+Contributor : Zhilian DAI 
+*/
+/* Class = "NSTextFieldCell"; title = "Rescan For Scales:"; ObjectID = "0hr-m8-QTZ"; */
+"0hr-m8-QTZ.title" = "重新扫描Emoji配置区间：";


I don't think this string should include Emoji as it's not referring to emoji characters specifically, it's referring to a 'scale' or theme to use when displaying battery status.

Hello, sorry for lated response, it seems some network problem occur on my email. Dose the "Rescan For Scales" means reload the scale configuration file?

@brianmichel ?

@DonaldDai "Rescan for Scale" it's also say "Rescan for theme"

@flayor What is the practical function?

Ho escuse me i don't see the email the .plist files can be a emoji, text, img ...

Hey folks, so sorry for taking a while to get back to you both. the "Rescan for scales" string could equally means "Rescan for configuration files", I'd like to avoid the usage of emoji in that particular string because users can create a configuration that is not emoji based at all.

Would it be easier if I changed this to say "Rescan for themes" ?

For now, I'm not familiar with the .plist file, so translation "重新加载配置文件" may be the best one. I will come back when I dive into it, it will not take too long : )

Sounds good, thanks! @DonaldDai

brianmichel · 2017-01-21T15:21:53Z

Juice/Classes/zh-Hans.lproj/GeneralPreferencesViewController.strings

+"0hr-m8-QTZ.title" = "重新扫描Emoji配置区间：";
+
+/* Class = "NSTextFieldCell"; title = "0 Scales Found"; ObjectID = "1EL-UD-CHx"; */
+"1EL-UD-CHx.title" = "未找到Emoji配置区间";


I don't think this string should include Emoji as it's not referring to emoji characters specifically, it's referring to a 'scale' or theme to use when displaying battery status.

this is should be "未找到配置区间"

brianmichel · 2017-01-21T15:22:00Z

Juice/Classes/zh-Hans.lproj/GeneralPreferencesViewController.strings

+"pSb-PT-l5y.title" = "当前区间：";
+
+/* Class = "NSButtonCell"; title = "Add Scale"; ObjectID = "xXL-NV-2xU"; */
+"xXL-NV-2xU.title" = "添加Emoji区间";


I don't think this string should include Emoji as it's not referring to emoji characters specifically, it's referring to a 'scale' or theme to use when displaying battery status.

Is this mean to add Emoji scale configuration?

It means to add a new scale which can also be though of as a theme.

Again, the scale is just a set of strings, which are not necessarily emojis at all.

Got it. So "添加配置" should be a good choice.

brianmichel · 2017-01-21T15:23:29Z

@flayor here's a screenshot of the Chinese and English side by side in reference to the comments I made on the PR

bnoufel · 2017-01-25T09:02:20Z

Hi

Sorry for the late response.

I have contact the guy Which translated into Chinese

No response for now

Sorry I fix this ASAP

DonaldDai · 2017-02-03T12:11:28Z

Ho… I'm asking you which edition do you want? The original one or the practical one? : ) Best, Donald On 2 Feb 2017, 21:47 +0800, Flayor <notifications@github.com>, wrote: @flayor commented on this pull request.

________________________________ In Juice/Classes/zh-Hans.lproj/GeneralPreferencesViewController.strings<#22>:

@@ -0,0 +1,24 @@

+ +/* +Contributor : Zhilian DAI +*/ +/* Class = "NSTextFieldCell"; title = "Rescan For Scales:"; ObjectID = "0hr-m8-QTZ"; */ +"0hr-m8-QTZ.title" = "重新扫描Emoji配置区间："; Ho escuse me i don't see the email the .plist files can be a emoji, text, img ... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANqe34rKkJgwON4boIJrfRGta7uvehKEks5rYd5egaJpZM4LkAC->.

bnoufel · 2017-02-05T12:20:37Z

The practical :) Bien cordialement Benjamin Noufel Le 3 févr. 2017 à 13:11 +0100, Zhilian Dai <notifications@github.com>, a écrit :

…

Ho… I'm asking you which edition do you want? The original one or the practical one? : ) Best, Donald On 2 Feb 2017, 21:47 +0800, Flayor ***@***.***>, wrote: @flayor commented on this pull request. ________________________________ In Juice/Classes/zh-Hans.lproj/GeneralPreferencesViewController.strings<#22>: > @@ -0,0 +1,24 @@ + +/* +Contributor : Zhilian DAI +*/ +/* Class = "NSTextFieldCell"; title = "Rescan For Scales:"; ObjectID = "0hr-m8-QTZ"; */ +"0hr-m8-QTZ.title" = "重新扫描Emoji配置区间："; Ho escuse me i don't see the email the .plist files can be a emoji, text, img ... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANqe34rKkJgwON4boIJrfRGta7uvehKEks5rYd5egaJpZM4LkAC->. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (#22 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AGSA0UDi3vfrP9TNI_weVGxgkjVzJxflks5rYxlxgaJpZM4LkAC-).

bnoufel · 2017-02-07T10:19:03Z

Hi @DonaldDai,

Sorry if i didn't answer, ..., i'm In full moving

Tell me here in this comment for the translate, I'm lost with all these different threads lol

DonaldDai · 2017-02-07T15:12:47Z

@flayor
"Rescan For Scales" = “重新加载配置文件”
"0 Scales Found" = “未找到配置区间”
"Add Scale" = “添加配置”

bnoufel · 2017-02-07T16:08:32Z

It's done @brianmichel
Thanks @DonaldDai

DonaldDai · 2017-02-11T00:54:52Z

：） On 2017年2月8日 +0800 AM12:08, Flayor <notifications@github.com>, wrote: It's done @brianmichel<https://github.com/brianmichel> Thanks @DonaldDai<https://github.com/DonaldDai> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANqe39CMmopSuBzu9qJR45A-EHCowPQJks5raJcBgaJpZM4LkAC->.

brianmichel · 2017-02-12T16:57:43Z

zh-Hans.lproj/Localizable.strings

+"General"="常规";
+"General Settings"="常规设置";
+"Credits"="开发者成员";
+"Scales Found"="Emoji电量范围";


This still mentions Emoji in it's translation and it should not.

brianmichel · 2017-02-12T16:57:53Z

zh-Hans.lproj/Localizable.strings

+"Error scanning application support directory"="寻找必要文件时出现错误";
+"title"="标题";
+"default"="默认";
+"detents"="Emoji范围配置";


This still mentions Emoji in it's translation and it should not.

"detents" = “打开配置文件”

bnoufel · 2017-03-11T18:35:35Z

Well all's feel good ?

brianmichel · 2017-03-12T14:47:02Z

@flayor looks good to me!

Flay0r added 12 commits December 22, 2016 22:31

translate en to fr

6340419

re add GeneralPreferencesViewController.xib

81b4868

re add devTeam origin && fix path GeneralPreferencesViewController.xib

dabb84f

fix fail

99122ed

re add old dev team

be57999

merge

702b845

Translate pref

63f2c35

translate settings en to fr

7cabfc0

translate settings en to fr

9f7de15

fix translation

fbfda09

translate en to chinese thanks you so much to Zhilian DAI :)

cc63e89

re add old dev team

d9ad44a

brianmichel self-requested a review January 19, 2017 14:17

brianmichel requested changes Jan 21, 2017

View reviewed changes

finish transtlate to chinise

0bd77c0

brianmichel reviewed Feb 12, 2017

View reviewed changes

fix translate

e49259c

brianmichel approved these changes Mar 12, 2017

View reviewed changes

brianmichel merged commit 3638e8c into brianmichel:master Mar 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translation #22

Translation #22

bnoufel commented Jan 15, 2017

brianmichel commented Jan 19, 2017

bnoufel commented Jan 19, 2017

brianmichel left a comment

brianmichel Jan 21, 2017

DonaldDai Jan 26, 2017 •

edited

Loading

DonaldDai Jan 29, 2017

bnoufel Jan 29, 2017 •

edited

Loading

DonaldDai Jan 29, 2017

bnoufel Feb 2, 2017

brianmichel Feb 5, 2017

brianmichel Feb 5, 2017

DonaldDai Feb 5, 2017

brianmichel Feb 5, 2017

brianmichel Jan 21, 2017

DonaldDai Feb 5, 2017

brianmichel Jan 21, 2017

DonaldDai Feb 5, 2017

brianmichel Feb 5, 2017

DonaldDai Feb 5, 2017

brianmichel commented Jan 21, 2017

bnoufel commented Jan 25, 2017

DonaldDai commented Feb 3, 2017 via email

bnoufel commented Feb 5, 2017 via email

bnoufel commented Feb 7, 2017 •

edited

Loading

DonaldDai commented Feb 7, 2017

bnoufel commented Feb 7, 2017

DonaldDai commented Feb 11, 2017 via email

brianmichel Feb 12, 2017

brianmichel Feb 12, 2017

DonaldDai Feb 13, 2017

bnoufel commented Mar 11, 2017

brianmichel commented Mar 12, 2017

Translation #22

Translation #22

Conversation

bnoufel commented Jan 15, 2017

brianmichel commented Jan 19, 2017

bnoufel commented Jan 19, 2017

brianmichel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DonaldDai Jan 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bnoufel Jan 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brianmichel commented Jan 21, 2017

bnoufel commented Jan 25, 2017

DonaldDai commented Feb 3, 2017 via email

bnoufel commented Feb 5, 2017 via email

bnoufel commented Feb 7, 2017 • edited Loading

DonaldDai commented Feb 7, 2017

bnoufel commented Feb 7, 2017

DonaldDai commented Feb 11, 2017 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bnoufel commented Mar 11, 2017

brianmichel commented Mar 12, 2017

DonaldDai Jan 26, 2017 •

edited

Loading

bnoufel Jan 29, 2017 •

edited

Loading

bnoufel commented Feb 7, 2017 •

edited

Loading