Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace crypto/ecdsa's signature verification with GFp #1

Closed
briansmith opened this issue Jul 23, 2015 · 1 comment
Closed

Replace crypto/ecdsa's signature verification with GFp #1

briansmith opened this issue Jul 23, 2015 · 1 comment
Assignees

Comments

@briansmith
Copy link
Owner

No description provided.

@briansmith briansmith self-assigned this Jul 23, 2015
briansmith pushed a commit that referenced this issue Aug 27, 2015
As I read it:

1. |_LHASH| contains
2.   buckets of |LHASH_ITEMS|, which contain
3.     |CONF_VALUE|s, which contain
4.       various bits of data.

The previous code was freeing #1 and #2 in |lh_free|, and #4 in
|value_free_contents|, but was failing to free the |CONF_VALUE|s
themselves.  The fix is to call |value_free| rather than
|value_free_contents|.

Change-Id: I1d5b48692ca9ac04df688e45d7fc113dc5cd6ddf
Reviewed-on: https://boringssl-review.googlesource.com/5742
Reviewed-by: Adam Langley <agl@google.com>
@briansmith
Copy link
Owner Author

I decided to merge the GFp project into ring so this doesn't make sense any more.

briansmith pushed a commit that referenced this issue Dec 30, 2017
#1

Change-Id: I92419b7d2d8ded8f4868588ad3c24b70ac7f7b1b
Reviewed-on: https://boringssl-review.googlesource.com/14864
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
seinlin pushed a commit to seinlin/ring that referenced this issue May 1, 2020
paulyoung pushed a commit to codebase-labs/ring that referenced this issue Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant