Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: Remove optimization for repository owner's PRs. #1258

Closed
wants to merge 1 commit into from

Conversation

briansmith
Copy link
Owner

The optimization avoids every CI job running twice for the repository owner's
PRs. This is a pretty useful optimization because there are so many slow jobs
that are run for every commit that are duplicated for each of my PRs. However,
in the interest of making CI as bulletproof as possible, I'm going to try to
eliminate this. We'll add it back, or similar, if things get too bad.

$ grep "if:" .github/workflows/ci.yml | sort | uniq
      - if: ${{ !contains(matrix.host_os, 'windows') }}
      - if: ${{ contains(matrix.host_os, 'ubuntu') }}
      - if: ${{ contains(matrix.host_os, 'windows') }}
      - if: ${{ matrix.target == 'aarch64-apple-darwin' }}

The optimization avoids every CI job running twice for the repository owner's
PRs. This is a pretty useful optimization because there are so many slow jobs
that are run for every commit that are duplicated for each of my PRs. However,
in the interest of making CI as bulletproof as possible, I'm going to try to
eliminate this. We'll add it back, or similar, if things get too bad.

```
$ grep "if:" .github/workflows/ci.yml | sort | uniq
      - if: ${{ !contains(matrix.host_os, 'windows') }}
      - if: ${{ contains(matrix.host_os, 'ubuntu') }}
      - if: ${{ contains(matrix.host_os, 'windows') }}
      - if: ${{ matrix.target == 'aarch64-apple-darwin' }}
```
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1258 (bbc3058) into main (f3d8b52) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1258   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files         116      116           
  Lines       18270    18270           
=======================================
  Hits        16967    16967           
  Misses       1303     1303           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d8b52...bbc3058. Read the comment docs.

@briansmith
Copy link
Owner Author

Unfortunately, the first CI attempt seems to have gotten hung up as pull request UI got stuck "expecting" the results from the rustdoc and tests jobs. Maybe it was a fluke. I see now, with this change, there are more than 256 total jobs. I wonder if I misunderstood the limits on jobs.

@briansmith
Copy link
Owner Author

The documentation says "Job matrix - A job matrix can generate a maximum of 256 jobs per workflow run." I'm not sure what that means though.

@briansmith
Copy link
Owner Author

It seems I need to avoid doing this for now, as we're apparently hitting that 256 job limit, I guess. The GitHub PR UI is looking strange during this run. I'll try to find a solution another time.

@briansmith briansmith closed this Apr 27, 2021
@briansmith briansmith deleted the b/i-am-not-special branch April 29, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant