chacha20_poly1305_openssh: Minimize and document panicking. #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return an error instead of panicking. Luckily, since the slicing is done after the Poly1305 verification is done, it won't be hit by anybody in practice unless Poly1305 is broken. Unfortunately, for the same reason, it is too hard to write a test. Also, the user will have needed to have already decrypted the packet length before calling `open_in_place`, which means they must have successfully parsed a packet length.
briansmith
force-pushed
the
b/avoid-panic-min
branch
from
50cf4e1 to
4f65d89
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2228 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 165 165
Lines 20500 20505 +5
Branches 463 464 +1
=======================================
+ Hits 19888 19893 +5
- Misses 504 505 +1
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for details.