Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chacha: Change name/signature of encrypt_{in_place,within}. #2236

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

briansmith
Copy link
Owner

See the individual commits for details.

@briansmith briansmith self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.96%. Comparing base (404b106) to head (ece5220).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/aead/chacha20_poly1305_openssh.rs 68.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
- Coverage   96.96%   96.96%   -0.01%     
==========================================
  Files         166      166              
  Lines       20553    20565      +12     
  Branches      463      463              
==========================================
+ Hits        19930    19940      +10     
- Misses        515      517       +2     
  Partials      108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Replace `Overlapping::in_place` with this conversion.
Rename `encrypt_within` to `encrypt`.
Replace `encrypt_in_place` with calls directly to `encrypt`.
@briansmith briansmith force-pushed the b/chacha-encrypt-cpu branch from c2e1c03 to f50630d Compare January 17, 2025 02:55
@briansmith briansmith force-pushed the b/chacha-encrypt-cpu branch from f50630d to ece5220 Compare January 17, 2025 03:15
@briansmith briansmith merged commit 35fb704 into main Jan 17, 2025
162 of 164 checks passed
@briansmith briansmith deleted the b/chacha-encrypt-cpu branch January 17, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant